fix closing invalid file descriptor with memory_io_buf #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks. |
yarikoptic
added a commit
to yarikoptic/vowpal_wabbit
that referenced
this pull request
Jun 9, 2019
* tag '8.7.0': (354 commits) Update version to 8.7.0 (VowpalWabbit#1926) Fix misconfiguration (VowpalWabbit#1925) Ataymano ataymano/warnings fixes (VowpalWabbit#1924) Update new version script (VowpalWabbit#1922) Run clang-format over codebase (VowpalWabbit#1921) change semantics of lambda (VowpalWabbit#1920) Bremen79 fix save ftrl (VowpalWabbit#1919) fix for daemon race condition (VowpalWabbit#1918) Revert "Fix to save the state of FTRL models (VowpalWabbit#1912)" (VowpalWabbit#1916) fix static library build (VowpalWabbit#1913) more warnings (VowpalWabbit#1915) Fix to save the state of FTRL models (VowpalWabbit#1912) remove warnings (VowpalWabbit#1911) fix closing invalid file descriptor with memory_io_buf (VowpalWabbit#1910) Optional exception (VowpalWabbit#1906) Contextual Memory Tree (VowpalWabbit#1799) Coin betting (VowpalWabbit#1903) Ataymano/c wrapper fix2 (VowpalWabbit#1859) Use Appveyor MSBuildLogger (VowpalWabbit#1904) fix for no label confidence (VowpalWabbit#1901) ...
yarikoptic
added a commit
to yarikoptic/vowpal_wabbit
that referenced
this pull request
Jun 9, 2019
* releases: (354 commits) Update version to 8.7.0 (VowpalWabbit#1926) Fix misconfiguration (VowpalWabbit#1925) Ataymano ataymano/warnings fixes (VowpalWabbit#1924) Update new version script (VowpalWabbit#1922) Run clang-format over codebase (VowpalWabbit#1921) change semantics of lambda (VowpalWabbit#1920) Bremen79 fix save ftrl (VowpalWabbit#1919) fix for daemon race condition (VowpalWabbit#1918) Revert "Fix to save the state of FTRL models (VowpalWabbit#1912)" (VowpalWabbit#1916) fix static library build (VowpalWabbit#1913) more warnings (VowpalWabbit#1915) Fix to save the state of FTRL models (VowpalWabbit#1912) remove warnings (VowpalWabbit#1911) fix closing invalid file descriptor with memory_io_buf (VowpalWabbit#1910) Optional exception (VowpalWabbit#1906) Contextual Memory Tree (VowpalWabbit#1799) Coin betting (VowpalWabbit#1903) Ataymano/c wrapper fix2 (VowpalWabbit#1859) Use Appveyor MSBuildLogger (VowpalWabbit#1904) fix for no label confidence (VowpalWabbit#1901) ...
yarikoptic
added a commit
to yarikoptic/vowpal_wabbit
that referenced
this pull request
Jun 9, 2019
* dfsg: (354 commits) Update version to 8.7.0 (VowpalWabbit#1926) Fix misconfiguration (VowpalWabbit#1925) Ataymano ataymano/warnings fixes (VowpalWabbit#1924) Update new version script (VowpalWabbit#1922) Run clang-format over codebase (VowpalWabbit#1921) change semantics of lambda (VowpalWabbit#1920) Bremen79 fix save ftrl (VowpalWabbit#1919) fix for daemon race condition (VowpalWabbit#1918) Revert "Fix to save the state of FTRL models (VowpalWabbit#1912)" (VowpalWabbit#1916) fix static library build (VowpalWabbit#1913) more warnings (VowpalWabbit#1915) Fix to save the state of FTRL models (VowpalWabbit#1912) remove warnings (VowpalWabbit#1911) fix closing invalid file descriptor with memory_io_buf (VowpalWabbit#1910) Optional exception (VowpalWabbit#1906) Contextual Memory Tree (VowpalWabbit#1799) Coin betting (VowpalWabbit#1903) Ataymano/c wrapper fix2 (VowpalWabbit#1859) Use Appveyor MSBuildLogger (VowpalWabbit#1904) fix for no label confidence (VowpalWabbit#1901) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix to an old PR of mine (#1189). When using memory_io_buf the parent close will attempt to close(-1). It didn't seem to cause any problems but I recently noticed this reported in valgrind output. This change overrides close_file to not make the close() syscall.