Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# bindings on .NET core 3.1 #2273

Closed
wants to merge 100 commits into from
Closed

C# bindings on .NET core 3.1 #2273

wants to merge 100 commits into from

Conversation

marat-turaev
Copy link

@marat-turaev marat-turaev commented Feb 19, 2020 •
edited
Loading

PR for #2272:

  • All *.csproj were converted to SDK-style to multitarget net452 and netcoreapp3.1
  • vw_netcore.vcxproj netcore C++/CLI project was added to target netcoreapp3.1
  • Streamlined VS2019 migration: MSVC v142 toolset & Windows SDK 10.0 now targeted
  • Other minor improvements

@marat-turaev
Small const char * fix;
a05d402 
Updated dependencies (VS 2019):
  PlatformToolset to v142
  WindowsTargetPlatformVersion to 10.0
  boost to 1.71.0.0
  boost_program_options-vc141 to boost_program_options-vc142 1.71.0.0
  boost_unit_test_framework-vc141 to boost_unit_test_framework-vc142 1.71.0.0
@marat-turaev
netcore31:
e42d46a 
  vw_common.csproj -> vw_common_netcore.csproj
  vw_clr.vcxproj -> vw_netcore.vcxproj
@marat-turaev
vw_netcore: added zlib
13557e2
@marat-turaev
Temporary removed libboost_po
87aaaa2
@marat-turaev
netcore31: cs -> netcore
bffb35e 
vw_netcore: removed zlib x86
@marat-turaev
vw_netcore: comments cleanup
3c0f389
@marat-turaev
Merge remote-tracking branch 'upstream' into netcore31
ac66294
@marat-turaev
netcore31:
def69f7 
  cs_console -> netcore_console
  cs_parallel -> netcore_parallel
  cs_json -> netcore_json
  simulator -> simulator_netcore
@marat-turaev
netcore31:
b78d3cf 
  cs_testcommon -> netcore_testcommon.csproj
  cs_unittest -> netcore_unittest.csproj
@marat-turaev
netcore31:
71f5e2b 
  cs_test -> netcore_test.csproj
@marat-turaev
Only x64 across sln
1aafed5
@marat-turaev
packages.config replaced with PackageReferences in cs project
80affb5
@marat-turaev
cs.csproj ported to SDK-style project file
f31e308
@marat-turaev
cs.csproj to be sdk-style project
286639d
@marat-turaev
Merge remote-tracking branch 'upstream/master' into netcore31
bd67178
@marat-turaev
cs.csproj to target both net452 and netcore3.1
81b2e3a 
vw_common.csproj to target both net452 and netcore3.1
vw_common_netcore.csproj deprecated and removed
@marat-turaev
netcore.csproj deprecated and removed
16471dc
@marat-turaev
cs_json.csproj to target both net452 and netcore3.1
e4d5d2a 
netcore_json.csproj deprecated and removed
@marat-turaev
cs_parallel.csproj to target both net452 and netcore3.1
cc278b4 
netcore_parallel.csproj deprecated and removed
@marat-turaev
cs_console.csproj simulator.csproj cs_testcommon.csproj to target bot…
589e151 
…h net452 and netcore3.1
@marat-turaev
cs_unittest.csproj to target both net452 and netcore3.1
6e17df1
@marat-turaev
cs_test.csproj to target both net452 and netcore3.1
e5f6e7c
@marat-turaev
vw_netcore.vcxproj moved inside cs/cli folder
9edf1b8
@marat-turaev
Solution file cleanup.
74c6e63
@marat-turaev
cs_test.csproj cleanup
75255d5
@marat-turaev
vw.sln cleanup
ffb48d1
@marat-turaev
Merge remote-tracking branch 'upstream/master' into netcore32
c4dfafa
@marat-turaev
vw_netcore.vcxproj reverted a few properties
447097e
@marat-turaev
Moved $(VowpalWabbitAssemblyVersion) to Directory.Build.props
d7d284d
@marat-turaev
nuspec in cs.csproj reverted
35ab4bc
@marat-turaev marat-turaev mentioned this pull request Mar 4, 2020
Closed
@thealphadollar
Copy link
Contributor

@marat-turaev Any updates on this? I guess this is in pretty good shape for a re-review.

@marat-turaev
Copy link
Author

@marat-turaev Any updates on this? I guess this is in pretty good shape for a re-review.

Yes, this PR is open for review.

@lokitoth lokitoth self-assigned this Mar 11, 2020
@lokitoth
Copy link
Member

Still working on reviewing this. Going to first see if I can understand what is causing Windows CI to fail.

@marat-turaev
Copy link
Author

Still working on reviewing this. Going to first see if I can understand what is causing Windows CI to fail.

Due to this VS 16.5 bug: https://developercommunity.visualstudio.com/content/problem/900965/vs-165-preview-20-problem-with-make-heap-unchecked.html

It's fixed with 16.6, builds ok with preview version: https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-preview

@lgtm-com
Copy link

lgtm-com bot commented May 15, 2020

This pull request introduces 6 alerts when merging 9846721 into 19fda26 - view on LGTM.com

new alerts:

  • 6 for Missing Dispose call on local IDisposable

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2020

This pull request fixes 6 alerts when merging be2a5a1 into fb8ca3c - view on LGTM.com

fixed alerts:

  • 6 for Missing Dispose call on local IDisposable

@leaomatheus
Copy link

Are there plans on merging this? I'd be also interested in it to enable .NET core support for a project that takes VW as a dependency.

@smiranda
Copy link

+1 interest

@lokitoth
Copy link
Member

Closing as completed via #3969

@lokitoth lokitoth closed this Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalo lalo lalo left review comments

Assignees

@lokitoth lokitoth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marat-turaev @thealphadollar @lokitoth @leaomatheus @smiranda @lalo