Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate confidence sequences in automl and epsilon_decay #4125

Merged
merged 43 commits into from
Sep 22, 2022

Conversation

bassmang
Copy link
Member

No description provided.

@bassmang bassmang changed the title feat: integrate confidence sequences in epsilon_decay feat: integrate confidence sequences in automl and epsilon_decay Sep 2, 2022
@lalo
Copy link
Collaborator

lalo commented Sep 14, 2022

don't merge yet

std::swap(configs[0], configs[winner_config_index]);
if (winner_config_index != 1) { std::swap(configs[1], configs[winner_config_index]); }

configs[2].state = config_state::Inactive;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference valid_config_size, clear all except first two

if (verbose)
{
auto& elements = _config_oracle.configs[estimators[live_slot].first.config_index].elements;
metrics.set_string("exclusionc_" + std::to_string(live_slot), VW::reductions::util::elements_to_string(elements));
nested_metrics.set_string(
"exclusionc_" + std::to_string(live_slot), VW::reductions::util::elements_to_string(elements));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check config type

@lalo lalo force-pushed the integrate_cs branch 2 times, most recently from 0a48584 to de6e8ff Compare September 15, 2022 15:29
@bassmang bassmang merged commit 774cbc4 into VowpalWabbit:master Sep 22, 2022
@bassmang bassmang deleted the integrate_cs branch September 22, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants