Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(csv): default label regardless of if label column present #4127

Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix(csv): default label regardless of if label column present #4127

merged 2 commits into from
Aug 22, 2022

Conversation

jackgerrits
Copy link
Member

When a parser produces an example the contract is that default_label is always called regardless of if a label exists in the data or not.

@jackgerrits jackgerrits merged commit 562deec into VowpalWabbit:master Aug 22, 2022
@jackgerrits jackgerrits deleted the csv_label_fix branch August 22, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgavrou olgavrou olgavrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @olgavrou