feat: simple thread pool #4137
Merged
feat: simple thread pool #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
reviewed
Sep 1, 2022
zwd-ms
reviewed
Sep 1, 2022
| std::packaged_task<ResultType()> task(std::bind(std::forward<F>(func), std::forward<Args>(args)...)); | ||
| std::future<ResultType> result(task.get_future()); | ||
|
|
||
| if (_threads.size() == 0) |
There was a problem hiding this comment.
what's the use case for initializing a thread pool with zero threads?
There was a problem hiding this comment.
maybe you don't want to branch your code based on zero threads vs more than one thread
plus this ensures that you don't just hang if you initialize with zero by mistake
There was a problem hiding this comment.
In my opinion initializing with zero threads should be an error. If the user doesn't want threading they shouldnt use a thread pool. It's not up to the thread pool to implement that
There was a problem hiding this comment.
I like to think as scaling naturally with the available resources without having to have a different code path (similar to std async)
jackgerrits
reviewed
Sep 1, 2022
jackgerrits
reviewed
Sep 1, 2022
jackgerrits
approved these changes
Sep 2, 2022
zwd-ms
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced to be used in LAS
will probably evolve to include some sort of thread pool interface
when there is no work to be done threads wait on a conditional variable
if thread pool is initialized with zero size then the tasks are just executed sequentially on the same thread that called the thread pool