feat: [LAS] use thread pool in LAS one_pass implementation #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
changed the title
olgavrou
commented
Sep 2, 2022
| row_index++; | ||
| } | ||
|
|
||
| for (auto& ft : _futures) { ft.get(); } |
There was a problem hiding this comment.
calculate_aomega_row could throw so we could wrap ft.get() in a try/catch and rethrow here (not sure how we would recover if we did not want to rethrow)
zwdnyc
approved these changes
Sep 2, 2022
zwd-ms
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.