test: [LAS ] add spanner tests and test file separation #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwd-ms
approved these changes
Sep 13, 2022
| @@ -47,7 +47,8 @@ struct AO_triplet_constructor | |||
| void one_pass_svd_impl::generate_AOmega(const multi_ex& examples, const std::vector<float>& shrink_factors) | |||
| { | |||
| auto num_actions = examples[0]->pred.a_s.size(); | |||
| auto p = std::min(num_actions, _d + 5); | |||
| // one pass SVD is going to be less accurate than two pass SVD so we need to over-sample a bit more | |||
| auto p = std::min(num_actions, _d + 10); | |||
There was a problem hiding this comment.
how do we know to use 5 or 10? shall this be a parameter?
There was a problem hiding this comment.
trial and error, we were between 5 and 10 initially, 5 made the unit test fail when switched from vanilla to one_pass but 10 was ok. You can essentially affect this number by tuning d so it seems like an overkill to tune this too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new tests in cb_las_spanner:
check_spanner_rejects_same_actionscheck_spanner_rejects_actions_that_are_linear_combinations_of_other_actions