Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check model weights for gd-based tests for forward and backward compat #4172

Merged
merged 12 commits into from
Oct 4, 2022
Merged

ci: check model weights for gd-based tests for forward and backward compat #4172

merged 12 commits into from
Oct 4, 2022

Conversation

bassmang
Copy link
Member

No description provided.

lokitoth
lokitoth approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@lokitoth lokitoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor thing: If possible, please memorialize our logic for checking the weights in the PR description, so it does not get lost over time

@bassmang bassmang changed the title ci: check model weights for gd-based tests ci: check model weights for gd-based tests for forward and backward compat Oct 4, 2022
@bassmang bassmang merged commit befbd66 into VowpalWabbit:master Oct 4, 2022
@bassmang bassmang deleted the check_model_weights_ci branch October 4, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterychang peterychang peterychang left review comments

@lalo lalo lalo left review comments

@olgavrou olgavrou olgavrou approved these changes

@lokitoth lokitoth lokitoth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bassmang @lalo @lokitoth @olgavrou @peterychang