Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace classes with structs for consistency #4205

Merged
merged 4 commits into from
Oct 7, 2022
Merged

refactor: replace classes with structs for consistency #4205

merged 4 commits into from
Oct 7, 2022

Conversation

bassmang
Copy link
Member

@bassmang bassmang commented Oct 7, 2022 •
edited
Loading

Also removes all public: by declaring public before private

@bassmang bassmang merged commit 29b2ee5 into VowpalWabbit:master Oct 7, 2022
@bassmang bassmang deleted the no_classes branch October 7, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassmang @jackgerrits