Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [LAS] don't use shared features during SVD calculation #4225

Merged
merged 7 commits into from
Oct 17, 2022
Merged

fix: [LAS] don't use shared features during SVD calculation #4225

merged 7 commits into from
Oct 17, 2022

Conversation

olgavrou
Copy link
Collaborator

  • don't include shared features in the A matrix, they are not relevant in the representation of the actions and mess up the linearity assumptions
  • and minor fix in vanilla impl
  • renaming

@zwd-ms zwd-ms self-requested a review October 14, 2022 21:16
@olgavrou olgavrou enabled auto-merge (squash) October 17, 2022 13:44
@olgavrou olgavrou merged commit cc0e987 into VowpalWabbit:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

@zwd-ms zwd-ms zwd-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olgavrou @jackgerrits @zwd-ms