Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: VW should not add anything to namespace std #4230

Merged
merged 2 commits into from
Oct 17, 2022
Merged

fix: VW should not add anything to namespace std #4230

merged 2 commits into from
Oct 17, 2022

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Oct 17, 2022 •
edited
Loading

While we still violate this in test code this fixes the issue in library code which is the most important thing.

Overloading operators in namespace std is not permitted. https://en.cppreference.com/w/cpp/language/extending_std

@jackgerrits jackgerrits merged commit 0aa74c1 into VowpalWabbit:master Oct 17, 2022
@jackgerrits jackgerrits deleted the nostd_ns_adds branch October 17, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgavrou olgavrou olgavrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @olgavrou