refactor: reduce build time #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronxu99
reviewed
Oct 19, 2022
| @@ -5,7 +5,7 @@ | |||
| #include "vw/common/vw_exception.h" | |||
| #include "vw/core/reductions/cb/cb_algs.h" | |||
| #include "vw/core/scope_exit.h" | |||
| #include "vw/core/vw.h" | |||
| // #include "vw/core/vw.h" | |||
There was a problem hiding this comment.
delete this line instead of commenting it out?
byronxu99
approved these changes
Oct 19, 2022
olgavrou
approved these changes
Oct 19, 2022
lalo
approved these changes
Oct 19, 2022
lalo
reviewed
Oct 19, 2022
| @@ -2,6 +2,8 @@ | |||
| // individual contributors. All rights reserved. Released under a BSD (revised) | |||
| // license as described in the file LICENSE. | |||
|
|
|||
| #define NOMINMAX | |||
There was a problem hiding this comment.
this used to be inside a ifdef _WIN32, is there a reason to not follow that
There was a problem hiding this comment.
CLI will only build on windows as far as I know so I figured it wasnt necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine my build time went from about 30s to 17s.