Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [LAS] remove unused implementations and set max actions default #4247

Merged
merged 3 commits into from
Oct 24, 2022
Merged

chore: [LAS] remove unused implementations and set max actions default #4247

merged 3 commits into from
Oct 24, 2022

Conversation

olgavrou
Copy link
Collaborator

@olgavrou olgavrou commented Oct 24, 2022 •
edited
Loading

  • default max actions set to 20
  • remove full spanner wasn't even being unit tested anymore
  • remove model weight is an overkill since we have vanilla (renamed to two_pass_svd) for more accuracy and potential debugging
  • renamed vanilla to two_pass_svd

@olgavrou olgavrou merged commit 598c5d6 into VowpalWabbit:master Oct 24, 2022
jackgerrits pushed a commit to jackgerrits/vowpal_wabbit that referenced this pull request Oct 25, 2022
@olgavrou @jackgerrits
chore: [LAS] remove unused implementations and set max actions default (
9a4a746 
VowpalWabbit#4247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgavrou @jackgerrits