feat: explore eval example target rate #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
changed the title
ataymano
reviewed
Nov 9, 2022
ataymano
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to tell explore_eval to target a specific number of examples to use while updating. The goal is to not go over the example count that we want
Added
block_sizeargument to explore_eval. This should be calculated by doing:#examples_in_file / #examples_to_use_during_updateThe examples will then be processed in blocks of
block_size. In each block one example can be used to update. If in that block none of the examples pass the threshold then the example quota is rolled over to the next block and the next block can select 2 examples to update and so on