Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split apart output and progressive log #4308

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

jackgerrits
Copy link
Member

No description provided.

@@ -1200,7 +1201,8 @@ base_learner* VW::reductions::bfgs_setup(VW::setup_base_i& stack_builder)
.set_save_load(save_load)
.set_init_driver(init_driver)
.set_end_pass(end_pass)
.set_output_example(VW::details::output_example_simple_label<bfgs>)
.set_output_example_prediction(VW::details::output_example_prediction_simple_label<bfgs>)
Copy link
Collaborator

@olgavrou olgavrou Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use either output or print in the name of both functions here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_output_example_prediction usually goes to a file, whereas the update usually goes to stdout

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true dat

@jackgerrits jackgerrits merged commit 28a2f9a into VowpalWabbit:master Dec 6, 2022
@jackgerrits jackgerrits deleted the refactor_split_output branch December 6, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants