Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use strong type for no pred #4343

Merged
merged 7 commits into from
Dec 14, 2022
Merged

feat: use strong type for no pred #4343

merged 7 commits into from
Dec 14, 2022

Conversation

jackgerrits
Copy link
Member

No description provided.

olgavrou
olgavrou approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@olgavrou olgavrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if something triggered this change?

@jackgerrits
Copy link
Member Author

No particular trigger, just seemed like an opportunity to be safer.

@jackgerrits jackgerrits merged commit d892965 into VowpalWabbit:master Dec 14, 2022
@jackgerrits jackgerrits deleted the strong_type_no_pred branch December 14, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olgavrou olgavrou olgavrou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @olgavrou