feat: [automl] config oracle cubic on top of quadratic #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
changed the title
lalo
force-pushed
the
quadcub
branch
3 times, most recently
from
e9a476c
to
fd132af
Compare
bassmang
approved these changes
Dec 20, 2022
| } | ||
|
|
||
| // This will generate configs based on the current champ. These configs will be |
There was a problem hiding this comment.
Can we keep/update this comment where needed?
jackgerrits
requested changes
Dec 20, 2022
| @@ -605,6 +610,172 @@ BOOST_AUTO_TEST_CASE(one_diff_impl_unittest_w_iterations) | |||
| test_hooks, num_iterations, seed); | |||
| } | |||
|
|
|||
| BOOST_AUTO_TEST_CASE(qbase_unittest_w_iterations) | |||
There was a problem hiding this comment.
New tests should be added to vowpalwabbit/core/tests
There was a problem hiding this comment.
I'll migrate all the file, since this is almost an exact copy of another test on this same file.
lalo
force-pushed
the
quadcub
branch
2 times, most recently
from
41babfc
to
a0b03e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.