Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stabilize unique_ptr based initialize function #4438

Merged
merged 7 commits into from
Jan 9, 2023

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Jan 6, 2023

I am essentially just stabilizing the initialize_experimental function which has been working well for quite some time. With the changes of adding skip_model_load and removing the custom stack functionality from the stable interface. The custom stack is still available from initialize_experimental

std::unique_ptr<VW::workspace> initialize(std::unique_ptr<config::options_i> options,
    std::unique_ptr<VW::io::reader> model_override_reader = nullptr, bool skip_model_load = false,
    driver_output_func_t driver_output_func = nullptr, void* driver_output_func_context = nullptr,
    VW::io::logger* custom_logger = nullptr);

@jackgerrits jackgerrits merged commit bed3722 into VowpalWabbit:master Jan 9, 2023
@jackgerrits jackgerrits deleted the unique_ptr_initialize branch January 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants