fix: [LAS] LAS not a cb adf common reduction, fixes metrics with LAS bug #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalo
reviewed
Jan 31, 2023
| @@ -315,7 +320,7 @@ VW::LEARNER::base_learner* make_las_with_impl(VW::setup_base_i& stack_builder, V | |||
| .set_output_example_prediction(explore_type::output_example_prediction) | |||
| .set_update_stats(explore_type::update_stats) | |||
| .set_print_update(explore_type::print_update) | |||
| .set_persist_metrics(explore_type::persist_metrics) | |||
| .set_persist_metrics(VW::cb_explore_adf::persist_metrics) | |||
There was a problem hiding this comment.
if you remove this set, would it be equivalent to this change?
olgavrou
changed the title
lalo
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LAS is enabled then two exploration algorithms are enabled and they both call
cb_explore_adf_common'spersist_metricsfunction which overrides the same keysFixed by making LAS a standalone reduction and not a cb adf common one