feat: initial WASM support #4562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jackgerrits
commented
Apr 10, 2023
•
jackgerrits
commented
- Properly compile out daemon mode with a compile feature
- Modernize the exposed API with the learnings of py-vowpal-wabbit-next API
- Consider compiling out search for additional size improvements
- Revisit illegal args
- Fix out of bounds in test
- Typescript package wrapping these bindings
- think about example format for embeddings
olgavrou
reviewed
Apr 20, 2023
| @@ -0,0 +1,46 @@ | |||
| # VW - WASM | |||
|
|
|||
| This module is currently very experimental. It is not currently built standalone and still requires the glue JS to function. Ideally it will be standalone WASM module eventually. | |||
There was a problem hiding this comment.
build the wasm blob standalone
jackgerrits
commented
Apr 24, 2023
olgavrou
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.