feat(CB_GF): correct update rule and simulation unit test #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
olgavrou
commented
Apr 18, 2023
olgavrou
commented
- allow multiple costs if graph feedback
jackgerrits
reviewed
Apr 18, 2023
| @@ -105,6 +105,7 @@ class cb_explore_adf_base | |||
| const multi_ex& ec_seq, VW::io::logger& logger); | |||
|
|
|||
| ExploreType explore; | |||
| static bool allow_multiple_costs; | |||
There was a problem hiding this comment.
Does this need to be static?
There was a problem hiding this comment.
yes since it is used in predict/learn which are static
There was a problem hiding this comment.
If there are two workspace instances in the same process, one using cb with graph feedback and one not using it then this static would essentially break that scenario.
If this needs to be dynamic based on the setup then the variable and learn/predict should be non static
There was a problem hiding this comment.
actually it doesn't need to be static and good point, updated
jackgerrits
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.