feat: WASM initial CB model API #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
commented
Apr 26, 2023
cheng-tan
reviewed
Apr 26, 2023
| @@ -40,6 +40,9 @@ void validate_options(const VW::config::options_i& options) | |||
| if (!options.get_positional_tokens().empty()) { THROW("Positional options are not allowed") } | |||
| } | |||
|
|
|||
| struct vw_model_basic; | |||
There was a problem hiding this comment.
can we remove Line 43 - 45 and set the default MinxIn on Line183? to be consistent with cb_vw_model?
There was a problem hiding this comment.
these need to be forward declared so that vw_model can be referenced in line 55
cheng-tan
approved these changes
Apr 26, 2023
lalo
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the cb model, the example is not opaque but a javasctipt object that the C++ side can inspect
Moved basic vw functionality out into
vw_model_basicclass which is used as a mixin for thevw_modelwhich is generic vw model implementation and the newly addedcb_vw_modelvw_model_basiccan be enhanced in the future with any other generic functionality