Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CB_GF): correct constraints, huge cleanup, and clip and normalize probabilities #4581

Merged
merged 20 commits into from
May 31, 2023

Conversation

olgavrou
Copy link
Collaborator

@olgavrou olgavrou commented May 8, 2023

test results are a bit less dramatic

@olgavrou olgavrou changed the title fix(CB_GF): clip and normalize probabilities fix(CB_GF): correct constraints, huge cleanup, and clip and normalize probabilities May 11, 2023
@olgavrou
Copy link
Collaborator Author

reviewed with Paul offline and extensively tested with cvxpy version so will merge

@olgavrou olgavrou merged commit 78e2811 into VowpalWabbit:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants