Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: anchor features cleanup #4646

Closed
wants to merge 1 commit into from
Closed

fix: anchor features cleanup #4646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions vowpalwabbit/core/src/reductions/interact.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,28 +28,6 @@ class interact
size_t num_features = 0;
};

bool contains_valid_namespaces(VW::features& f_src1, VW::features& f_src2, interact& in, VW::io::logger& logger)
{
// first feature must be 1 so we're sure that the anchor feature is present
if (f_src1.size() == 0 || f_src2.size() == 0) { return false; }

if (f_src1.values[0] != 1)
{
// Anchor feature must be a number instead of text so that the relative offsets functions correctly but I don't
// think we are able to test for this here.
logger.err_error("Namespace '{}' misses anchor feature with value 1", static_cast<char>(in.n1));
return false;
}

if (f_src2.values[0] != 1)
{
logger.err_error("Namespace '{}' misses anchor feature with value 1", static_cast<char>(in.n2));
return false;
}

return true;
}

void multiply(VW::features& f_dest, VW::features& f_src2, interact& in)
{
f_dest.clear();
Expand Down Expand Up @@ -102,7 +80,7 @@ void predict_or_learn(interact& in, VW::LEARNER::learner& base, VW::example& ec)
VW::features& f1 = ec.feature_space[in.n1];
VW::features& f2 = ec.feature_space[in.n2];

if (!contains_valid_namespaces(f1, f2, in, in.all->logger))
if (f1.empty() || f2.empty())
{
if (is_learn) { base.learn(ec); }
else { base.predict(ec); }
Expand Down
Loading