Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ApplicationCommandChoice value to be 0 #80

Open
wants to merge 1 commit into
base: rewrite
Choose a base branch
from

Conversation

iHeroGH
Copy link
Member

@iHeroGH iHeroGH commented Feb 11, 2024

Summary

Originally, value = value or name would set the value to the name attribute if the value was 0.

This change prevents that by explicitly checking if the value is None rather than 0.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Originally, value = value or name would set the value to the name attribute if the value was 0. 

This change prevents that by explicitly checking if the value is None rather than 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant