Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typehinting across the Novus rewrite #81

Open
wants to merge 8 commits into
base: rewrite
Choose a base branch
from

Conversation

schlopp
Copy link
Contributor

@schlopp schlopp commented Apr 29, 2024

Summary

This PR consists of additional typehints I've provided to the Novus rewrite to reduce the amount of possible bugs and misinterpretations. These changes are nitpicky on their own, but all of them combined will be pretty significant.

This PR isn't finished - I'm still getting a reported 95 possible issues hehe - and will be gradually updated with new typehints. I'm personally using pyright to find these possible issues.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant