Minor Data Layer Fixes Oct 2020 #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated JSDoc comments for `Mongo.Collection.prototype.addField()` and fixed a minor bug. * Updated `validateModifier()` to include `documentId` in the context of custom field validators. Validators can use it to make sure that a value is unique in the collection. Without the `documentId`, the validator can't tell if an existing document with a unique value is being updated or if a new document with a conflicting value is attempted to be inserted. * Updated default resolvers to include the collection name when throwing a `missing_document` error.
|
Hi @SachaG! I noticed that you have reverted my change to I wonder if you meant to do that. I am not sure if you have seen my explanation for that change (please see above). Could we discuss this further? As I mentioned it looks to me that the usage of |
|
Hi I have the same issue due to this modification be86cc7#diff-6bef4e846751805d4e7f0e4bc392cc8125125fdaae89046b5e0fc06233eb8e38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongo.Collection.prototype.addField()and fixed a minor bug.validateModifier()to includedocumentIdin the context of custom field validators. Validators can use it to make sure that a value is unique in the collection. Without thedocumentId, the validator can't tell if an existing document with a unique value is being updated or if a new document with a conflicting value is attempted to be inserted.missing_documenterror.