Bundle lines parsed more than once

[jdevera]

I'm stuck in the events branch and I was trying to put an end to that by implementing Bundle! and the name override.

I started with the name override but got stuck where I found that multiple calls to vundle#config#init_bundle were issued in the code. It appears that the installer uses the Bundle lines in vimrc to write the installer screen and then reparses them in order to perform the actual installation. This means that any options passed to the Bundle command that deal with the installation itself, i.e. nosync() or a custom name, get lost in the process.

I have a suggestion for a modification of this behaviour but unfortunately I have not been able to implement it myself. I thought we could parse the bundles once with all their options and add them to a bundles dictionary (perhaps using expanded url as key or simply the name_spec and a fully parsed bundle "object" as value). Then the installer can read the Bundle line and retrieve the bundle "object" from the dictionary, with all the original options.

Let me know what you think.

[gmarik]

well, an easy fix would be: just filter out Bundles with disabled sync which are to be installed.
a harder one: refactor )

[jdevera]

the easy fix is also only a partial fix for the Bundle! case only, but it would not solve the name override problem or other options,like the one used in the v branch to specify something to checkout after cloning.

[MarcWeber]

status update or close?

[jdevera]

This is already fixed, now the installer reuses preparsed bundles.