Store bundles in a sorted dictionary #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By storing bundles in a sorted dictionary (dictionary + list of keys), the bundle does not need to be reparsed during installation if it has already been initialised, and any additional options passed in the original command are kept. This changeset is also an initial attempt to stabilise the name vs spec naming convention, where a bundle spec is whatever is used to specify a bundle, be it a name, user/name, full uri, etc., and name is the name of the bundle that will become a directory under the bundles directory. closes #1
|
Hey @jdevera. Don't have the answer yet... |
This changeset allows the second parameter of the Bundle command (a
dictionary) to override bundle object fields that come from parsing the
bundle spec. This means that
Bundle 'abolish.vim', {'name' : 'abo'}
will be installed in a bundle directory named 'abo', rather than
'abolish.vim', which is the name parsed from the bundle spec.
|
I just added a little something that was missing, please consider the second commit as well (that one won't take you a long time) |
|
@gmarik Just a reminder. I'm gonna do this a lot. lol |
|
Although I think this implementation was superior, since it used Viml dictionaries rather then iterating on lists, the problem this solved no longer exists, since we now reuse previously loaded bundle objects. So closing. But I might come back 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By storing bundles in a sorted dictionary (dictionary + list of keys), the bundle does not need to be reparsed during installation if it has already been initialised, and any additional options passed in the original command are kept.
This changeset is also an initial attempt to stabilise the name vs spec naming convention, where a bundle spec is whatever is used to specify a bundle, be it a name, user/name, full uri, etc., and name is the name of the bundle that will become a directory under the bundles directory.
This changeset is the foundation for a couple more that I intend to implement, I've listed them as issues in my fork, please let me know what you think.
I have tested these changes with a modification of the minimal vimrc (to include couple more bundles) and with my own vimrc with some modifications to make it compatible (I'm stuck in the events branch, but this is one step on the way out).
Also, I added some comments while I was trying to figure out the code, I left them there, I thought they wouldn't do any harm.
So, what do you think, is this vundle material?
This is in response to the conversation in #87