Use the global bundles instead of reinitializing #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, I had a much more complex implementation in pull request #109 to accomplish something similar. Never thought of simply traversing the list. I wonder if it wouldn't be a hit performance wise if you have lots of bundles, but I'd +1 this anyway, it opens the door to a lot of functionality, basically bringing any setting to the point where the bundles are actually fetched, i.e., checking out specific branches, doing shallow clones, etc. |
Closed
|
I have accidently close this PR, please refer to #242. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to let additional information of a Bundle to be used like in commit weynhamz/vim-plugin-vundle@f88bdbf. It is part of a PR #200 I previously submitted and been rejected due to duplication.