improved compatibility: vundle should now support vim >= 7.0 (#2) #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added new functions to detach caller from having to call
fnameescape() (which isn't available until vim-7.2):
* s:compat_rtp_rm_entry(dirs): abstracts 'set rtp-=LIST';
* s:compat_rtp_addset_entry(dirs, addset_operator):
abstracts 'set rtp+=LIST', 'set rtp^=LIST',
'set rtp=LIST';
* created autoload/vundle/compat.vim: "compatibility" module
(implements functions not available in previous vim versions);
(code taken from my previous commit in 'autoload/vundle/config.vim',
then modified and extended);
* added compatibility function for shellescape();
* autoload/vundle/config.vim: tidied up so that it's a bit closer to
the file upstream;
* (previous commit) but added a few performance improvements (avoid
unnecessary calls and/or operations);
* altered other scripts to use 'vundle#compat#*()' functions instead of
those not necessarily available in previous vim versions;
* use local variable in filter expression (filter()); * moved comments regarding future changes to the bottom of the file;
|
Original pull request: #354 |
|
I'm sorry I've created another pull request. I hadn't noticed that github would automatically include "pushed" commits in my development branch (although it actually didn't do that (for quite a few minutes/seconds), AFAICT). Live and learn. |
Closed
|
👍 |
Conflicts: autoload/vundle/config.vim autoload/vundle/installer.vim autoload/vundle/scripts.vim test/vimrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen that vundle seemed to only run on vim >= 7.2 (mainly due to the reliance on fnameescape()), so I've decided to create the 'autoload/vundle/compat.vim' file to provide implementations for both "new" (and "supporting") vim versions, and also for those vim versions that didn't provide those functions.
I've tested using BundleList, BundleInstall, BundleSearch, manually getting the list of packages ('R' on the BundleList). It all seems to work fine (some of the plugins that you can load through 'Bundle' aren't really that good at detecting whether vim supports them or not).
These changes don't seem to have "worsened" vundle in any perceivable way (not at least in the way I've been using it), so I reckon you should be happy to pull :-)
This includes changes triggered by jdevera's review comments.