-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS-6883] Add the Inline ad sample page #23
Conversation
@@ -0,0 +1,20 @@ | |||
// | |||
// LOInlineViewController.h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is LOInlineViewController
-> LOInLineViewController
?
@end | ||
|
||
|
||
@interface InlineModel : NSObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space between InlineModel
and :
? Thanks a lot. :)
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra line?
} | ||
} | ||
|
||
@IBAction func btnPressed(_ sender:UIButton) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this button for? no-op?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
self.imageView?.image = UIImage(named: "Liftoff-monetize-demo") | ||
} | ||
|
||
override func setSelected(_ selected: Bool, animated: Bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this override since it doesn't do anything? Or is Xcode requiring this?
super.awakeFromNib() | ||
} | ||
|
||
override func setSelected(_ selected: Bool, animated: Bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this override since it doesn't do anything? Or is Xcode requiring this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved this PR.
But, I'd like to update as I commented in future.
} | ||
} | ||
|
||
@IBAction func btnPressed(_ sender:UIButton) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
adModel.isAd = true | ||
adModel.cellHeight = 300 | ||
models.insert(adModel, at: 1) | ||
adCell.contentView.addSubview(bannerView) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you place the InLine ads at center of adCell
?
It's very minor but this is public facing app and it'd better to be looked good.
} | ||
|
||
func bannerAdWillPresent(_ bannerView: VungleAdsSDK.VungleBannerView) { | ||
print("bannerAdWillPresent") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, you need to add callbacks to tableView
as we did for other ad types?
No need to update with this PR. but for future improvement.
return model.cellHeight; | ||
} | ||
|
||
#pragma mark - VungleInterstitial Delegate Methods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space after this
} | ||
|
||
- (void)bannerAdWillPresent:(VungleBannerView * _Nonnull)bannerView { | ||
NSLog(@"bannerAdWillPresent"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add callbacks to the table to display
@ashinagawa @stanley-vungle @YueVungle thanks for your review. will update it in another pr. |
This commit will add the Inline ad sample page to the demo app.
IOS-6883