[IOS-6883] Add the Inline ad sample page #23
Conversation
bobVungle
requested review from
crbinsf,
ashinagawa,
felixzhang0703,
YueVungle,
HuFangshuai,
stanley-vungle and
ManojBudumuru-vungle
| @@ -0,0 +1,20 @@ | |||
| // | |||
| // LOInlineViewController.h | |||
There was a problem hiding this comment.
The name is LOInlineViewController -> LOInLineViewController?
| @end | ||
|
|
||
|
|
||
| @interface InlineModel : NSObject |
There was a problem hiding this comment.
Extra space between InlineModel and :? Thanks a lot. :)
| } | ||
|
|
| } | ||
| } | ||
|
|
||
| @IBAction func btnPressed(_ sender:UIButton) { |
| self.imageView?.image = UIImage(named: "Liftoff-monetize-demo") | ||
| } | ||
|
|
||
| override func setSelected(_ selected: Bool, animated: Bool) { |
There was a problem hiding this comment.
Can you remove this override since it doesn't do anything? Or is Xcode requiring this?
| super.awakeFromNib() | ||
| } | ||
|
|
||
| override func setSelected(_ selected: Bool, animated: Bool) { |
There was a problem hiding this comment.
Can you remove this override since it doesn't do anything? Or is Xcode requiring this?
| } | ||
| } | ||
|
|
||
| @IBAction func btnPressed(_ sender:UIButton) { |
| adModel.isAd = true | ||
| adModel.cellHeight = 300 | ||
| models.insert(adModel, at: 1) | ||
| adCell.contentView.addSubview(bannerView) |
There was a problem hiding this comment.
Can you place the InLine ads at center of adCell?
It's very minor but this is public facing app and it'd better to be looked good.
| } | ||
|
|
||
| func bannerAdWillPresent(_ bannerView: VungleAdsSDK.VungleBannerView) { | ||
| print("bannerAdWillPresent") |
There was a problem hiding this comment.
Ideally, you need to add callbacks to tableView as we did for other ad types?
No need to update with this PR. but for future improvement.
| return model.cellHeight; | ||
| } | ||
|
|
||
| #pragma mark - VungleInterstitial Delegate Methods |
| } | ||
|
|
||
| - (void)bannerAdWillPresent:(VungleBannerView * _Nonnull)bannerView { | ||
| NSLog(@"bannerAdWillPresent"); |
There was a problem hiding this comment.
Add callbacks to the table to display
|
@ashinagawa @stanley-vungle @YueVungle thanks for your review. will update it in another pr. |
This commit will add the Inline ad sample page to the demo app.
IOS-6883