[IOS-2992]Set CCPA status at adapter level #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashinagawa
reviewed
May 12, 2020
| [[VungleSDK sharedSDK] updateCCPAStatus:ccpaStatus]; | ||
| } | ||
|
|
||
| + (VungleCCPAStatus)getCCPAStatus { |
There was a problem hiding this comment.
@YueVungle Can users access to VungleCCPAStatus without including VungleSDK.h? If not, we might need to add similar enum at adapter level, and adapter should convert it to VungleCCPAStatus. I can see we did wrong for "VungleConsentStatus" since it requires to include VungleSDK.h.
There was a problem hiding this comment.
@ashinagawa Hi Aki, got it, I will add the similar enum in Adapter level. Thanks a lot for the reminder. ^_^
There was a problem hiding this comment.
@ashinagawa Hi Aki, updated, thanks a lot for the guidance. ^_^
crbinsf
approved these changes
May 14, 2020
YueVungle
force-pushed
the
6.7.x_pre_release
branch
from
019a448
to
313bb13
Compare
YueVungle
force-pushed
the
6.7.x_pre_release
branch
from
3cd5cd6
to
22c8ebe
Compare
YueVungle
force-pushed
the
6.7.x_pre_release
branch
from
af5bb23
to
b8c545d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding CCPA, there are concerns raised by IE team about setting CCPA via SDK instead via adapters.
For AdMob Adapter, we need to open api through public header
VungleRouterConfigurationor else, I think the public headVungleRouterConfigurationis suitable to set CCPA status.IOS-2992