-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS-2992]Set CCPA status at adapter level #25
base: 6.7.x_pre_release
Are you sure you want to change the base?
Conversation
[[VungleSDK sharedSDK] updateCCPAStatus:ccpaStatus]; | ||
} | ||
|
||
+ (VungleCCPAStatus)getCCPAStatus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YueVungle Can users access to VungleCCPAStatus
without including VungleSDK.h
? If not, we might need to add similar enum at adapter level, and adapter should convert it to VungleCCPAStatus
. I can see we did wrong for "VungleConsentStatus" since it requires to include VungleSDK.h
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashinagawa Hi Aki, got it, I will add the similar enum in Adapter level. Thanks a lot for the reminder. ^_^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashinagawa Hi Aki, updated, thanks a lot for the guidance. ^_^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!!
LGTM!!
019a448
to
313bb13
Compare
3cd5cd6
to
22c8ebe
Compare
af5bb23
to
b8c545d
Compare
Regarding CCPA, there are concerns raised by IE team about setting CCPA via SDK instead via adapters.
For AdMob Adapter, we need to open api through public header
VungleRouterConfiguration
or else, I think the public headVungleRouterConfiguration
is suitable to set CCPA status.IOS-2992