Return MREC ad size for fluid banner size #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With GAM support of fluid banner sizes (providing 0,0 as the banner size for the ad to be requested), this change will allow for the VungleSDK to request an MREC ad when the fluid size is included in the ad load request. IOS-6609
|
@stanley-vungle , @ashinagawa - changes here allow for testing of adapter change in this PR - https://github.com/Vungle/admob-adapter-testapp-ios/pull/53 |
stanley-vungle
requested review from
YueVungle,
ManojBudumuru-vungle and
bobVungle
ashinagawa
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Changes look good.
But, I couldn't verify it with test app as I added comment in https://github.com/Vungle/admob-adapter-testapp-ios/pull/53
stanley-vungle
approved these changes
Feb 22, 2024
This commit updates the adapter code to work with fluid banner testing. It sets a fluid banner ad size when the initial banner request is received and converts that to a MREC size before the SDK load method is called. When the adapter is about to call the SDK present method, the adapter updates the presenting bannerView size to the expected MREC size to prevent errors in the SDK. Comments added to help with testing.
YueVungle
reviewed
Mar 7, 2024
| #pragma mark - VungleBannerDelegate | ||
|
|
||
| - (void)bannerAdDidLoad:(nonnull VungleBanner *)banner { | ||
| CGSize updatedBannerSize = [self updateBannerViewSizeIfNeeded]; |
There was a problem hiding this comment.
The indentations of the lines in this method is different. Thanks a lot. :)
YueVungle
reviewed
Mar 7, 2024
| (adSize.size.height == 0 && adSize.size.width == 0)) { | ||
| // if ((adSize.size.height >= GADAdSizeMediumRectangle.size.height && | ||
| // adSize.size.width >= GADAdSizeMediumRectangle.size.width) || | ||
| // (adSize.size.height == 0 && adSize.size.width == 0)) { |
There was a problem hiding this comment.
Because above lines are commented out, might we need to update below comment:
// VungleSDK will return MREC ad for 300 X 250 and greater OR
// for 0,0 provided sizes
to
// VungleSDK will return MREC ad for 300 X 250 and greater
Thanks a lot. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GAM support of fluid banner sizes (providing 0,0 as the banner size for the ad to be requested), this change will allow for the VungleSDK to request an MREC ad when the fluid size is included in the ad load request.
IOS-6609