-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cure threshold #2
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 140 the parameter "df_survival_curves" reflect survival before the the time of threshold this is causing an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not reproduce the error, @Khader-Habash!
I have added two sets of tests, one for when the 'cure threshold' assumption is employed and one for when it is not. Both tests pass fine on my system.
I also changed the way the Markov trace is checked.
Can you pull the latest changes and run the tests on your machine using devtools::test()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ative survival multiplied by the percentage of the population alive at the time of the cure threshold.
This branch adds a vignette explaining how the cure threshold is implemented. The following plots are included in that vignette.
The package is now ready for Jordan data and results.