Cure threshold #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-Mohammed
requested review from
Khader-Habash,
abeero126,
RazanSawalha and
ashatala
There was a problem hiding this comment.
line 140 the parameter "df_survival_curves" reflect survival before the the time of threshold this is causing an error
There was a problem hiding this comment.
I can not reproduce the error, @Khader-Habash!
I have added two sets of tests, one for when the 'cure threshold' assumption is employed and one for when it is not. Both tests pass fine on my system.
I also changed the way the Markov trace is checked.
Can you pull the latest changes and run the tests on your machine using devtools::test()?
…ative survival multiplied by the percentage of the population alive at the time of the cure threshold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a vignette explaining how the cure threshold is implemented. The following plots are included in that vignette.
The package is now ready for Jordan data and results.