Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simplistic Agv support #53

Merged
merged 24 commits into from
Sep 3, 2024
Merged

added simplistic Agv support #53

merged 24 commits into from
Sep 3, 2024

Conversation

liquidcronos
Copy link
Member

@liquidcronos liquidcronos commented Dec 22, 2023

Description

In order to simulate interactions between robots and intralogistic systems a simple agv class was setup that is meant to simplify agv simulations.
A base template class was developed for different kinematics and a differential drive kinematic childclass was implemented.

Motivation and Context

This change is needed to simulate production cells where the workpiece is delivered by an intra logicstics system in this case an agv.

How has this been tested?

Each class method has been unit tested against precomputed values.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: Patch coverage is 92.47312% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.14%. Comparing base (fc4d1f4) to head (9214191).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/pybullet_industrial/agv_robots.py 92.39% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   87.75%   88.14%   +0.38%     
==========================================
  Files          16       17       +1     
  Lines        1037     1130      +93     
==========================================
+ Hits          910      996      +86     
- Misses        127      134       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaHajo MaHajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented everything that came to mind, if you think thats bullshit feel free to ignore the comments :D
Feedback on the review itself is welcome!

examples/agv_robot.py Show resolved Hide resolved
examples/agv_robot.py Show resolved Hide resolved
examples/agv_robot.py Outdated Show resolved Hide resolved
src/pybullet_industrial/agv_robots.py Outdated Show resolved Hide resolved
src/pybullet_industrial/agv_robots.py Show resolved Hide resolved
src/pybullet_industrial/agv_robots.py Show resolved Hide resolved
src/pybullet_industrial/agv_robots.py Show resolved Hide resolved
src/pybullet_industrial/agv_robots.py Show resolved Hide resolved
src/pybullet_industrial/agv_robots.py Show resolved Hide resolved
tests/test_agv_robots.py Show resolved Hide resolved
@liquidcronos liquidcronos requested a review from MaHajo April 3, 2024 08:16
@liquidcronos liquidcronos merged commit 001da11 into main Sep 3, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants