Only running search after input is finished #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you fix?
Hard-coded a .5s (configurable) buffer in between the last change to the search and the final load, so that we weren't regenerating the search every single time.
"One is that some people were requesting searches in the various windows to only take effect when you press enter or similar, since the constant updates cause a fair bit of lag. "
Reproduction steps
Evidence/screenshot/link to line
https://gyazo.com/804e83bc2e6b2378afd819d5b89a46ab for gif of usage
Considerations