Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only running search after input is finished #258

Merged
merged 3 commits into from
Feb 18, 2023
Merged

Conversation

PKFire813
Copy link
Contributor

@PKFire813 PKFire813 commented Dec 29, 2022

What did you fix?

Hard-coded a .5s (configurable) buffer in between the last change to the search and the final load, so that we weren't regenerating the search every single time.

"One is that some people were requesting searches in the various windows to only take effect when you press enter or similar, since the constant updates cause a fair bit of lag. "

Reproduction steps


Evidence/screenshot/link to line

https://gyazo.com/804e83bc2e6b2378afd819d5b89a46ab for gif of usage

Considerations

@PeterJeff
Copy link
Contributor

I'll run this in my builds for a while just to be but so far it seems sensible and works.

I'm just some interested rando though.

@dimon222 dimon222 self-requested a review February 18, 2023 23:09
Copy link
Member

@dimon222 dimon222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimon222 dimon222 merged commit 5cb35b9 into WFCD:master Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants