Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited GeForce Now support, Changed Snap It error behaviour (plus some more) #266

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

D1firehail
Copy link
Contributor

What did you fix?

  • closes GeForce Now Support #260 - Depends on stream quality, but some features should work
    • See "LimitationNotes" object in GFNWarning.xaml for detailed notes
  • Replaced Snap-it error popup on high noise, now gives warning triangle on items with high levenshtein distance or multiple tied closest match
    • Snap-it instead gives an error popup if no results were displayed
  • Removed Launcher folder and csproj, deprecated
  • Fixed log message always saying the screen is secondary, even for primary screen
  • Fixed ThemeAdjuster "Load Last Use" loading the oldest fullscreenshot instead of the newest

Reproduction steps

GeForce Now Detection

  1. Open WFInfo and GeForce Now in any order
    • Any process with title containg both of "GeForce NOW" and "Warframe" is accepted
    • There's no way to differentiate being in-game from being in queue
    • Closing of game may not be detected unless the entire program (GeForce Now or your browser) is closed
  2. Read notice about limited functionality that pops up
  3. Manually select theme
  4. Try using reward screen scan or snap-it
  5. If accuracy is below expectation, select and configure custom theme

GeForce Now WFM status handling

  1. Open WFInfo and GeForce Now in any order
    • Any process with title containg both of "GeForce NOW" and "Warframe" is accepted
    • There's no way to differentiate being in-game from being in queue
    • Closing of game may not be detected unless the entire program (GeForce Now or your browser) is closed
  2. If you're not already logged in with WFM, log in
  3. WFM online status is now set to online
  4. WFM online status will not change, except for manual changes made on main window or WFM website

Snap It error handling

  1. Use snap-it on a high noise image
  2. See if error popup happens
  3. See which items get a warning triangle (if any), and check them extra closely instead of blindly trusting results

Primary/Secondary screen logging

  1. Start WFInfo and game (or GFN)
  2. See log message containing the string Warframe display

ThemeAdjuster "Load Last Use"

  1. Open Theme Adjuster
  2. Click "Load Last Use"
  3. Look at which image from debug folder was loaded

Evidence/screenshot/link to line

Most changes are split into their own commit. If you need any clarification, just ask
Due to queue times and quality of my connection (and free tier), the GeForce Now features have been tested to a much extent than usual

Considerations

  • Does this contain a new dependency? [No]
  • Does this introduce opinionated data formatting or manual data entry? [No]
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [No]
  • Have I run the linter? [No]
  • Is is a bug fix, feature request, or enhancement? [Bug Fix/Feature/Enhancement]

@dimon222 dimon222 self-requested a review March 4, 2023 14:27
Copy link
Member

@dimon222 dimon222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimon222 dimon222 merged commit d77657f into WFCD:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GeForce Now Support
2 participants