fix: better filtering before creating joinable object

WFCD · Aug 11, 2018 · b2cfb44 · b2cfb44
1 parent f95f3d9
commit b2cfb44
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/settings/DatabaseQueries/PrivateRoomQueries.js b/src/settings/DatabaseQueries/PrivateRoomQueries.js
@@ -51,7 +51,7 @@ class PrivateRoomQueries {
           return undefined;
         }).filter(role => role).map((role) => {
           const parsed = JSON.parse(role);
-          if (typeof parsed === 'object') {
+          if (typeof parsed === 'object' && guild.roles.has(parsed.id)) {
             const joinable = new JoinableRole(guild.roles.get(parsed.id));
             if (typeof parsed.requiredRole !== 'undefined') {
               joinable.requiredRole = guild.roles.has(parsed.requiredRole)
@@ -60,7 +60,7 @@ class PrivateRoomQueries {
             }
             joinable.isLeaveable = typeof parsed.leaveable !== 'undefined' ? parsed.leavable : true;
             return joinable;
-          } if (typeof parsed === 'string') {
+          } if (typeof parsed === 'string' && guild.roles.has(parsed)) {
             const joinable = new JoinableRole(guild.roles.get(parsed));
             joinable.requiredRole = undefined;
             joinable.isLeaveable = true;