Create test files for moving sectioning commands to their own line #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Of course, the new tests do not pass at the moment, so I will leave this open until the feature has been implemented. |
cdesaintguilhem
force-pushed
the
pr-test-sections
branch
from
e18f7cf to
f71cfa2
Compare
|
Can this behaviour be implemented using the new regexes introduced in #42 ? |
|
Most probably, yes. Now that #42 has been merged, I can base a branch on that and check whether it's enough to use the existing splitting regex with maybe an additional one for the |
|
Closing this PR because it's superseded by #45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #13; it adds two test files that capture the expected behaviour for formatting sectioning commands: if such a command is on a line with other text, it should be moved to its own line. This should apply to all sectioning commands present on the same line. However (as discussed), no new empty lines should be added around the new line to which the sectioning command was moved.