Spec for aggregate debug reporting reports generation and delivery #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com> Spec for aggregate debug reporting reports generation and delivery
apasel422
requested changes
May 31, 2024
| @@ -4196,6 +4466,12 @@ To <dfn>generate a verbose debug report URL</dfn> given a [=verbose debug report | |||
| 1. Return the result of running [=generate a report URL=] with |report|'s | |||
| [=verbose debug report/reporting origin=] and |path|. | |||
|
|
|||
| To <dfn>generate an aggregatable debug report URL</dfn> given an [=aggregatable debug report=] |report|: | |||
|
|
|||
| 1. Let |path| be «"`debug`", "`report-aggregate-debug`"». | |||
There was a problem hiding this comment.
Are we intentionally including debug twice in the path?
There was a problem hiding this comment.
I think it makes sense to be in debug path, and explicit report-aggregate-debug is to distinguish from report-aggregate-attribution.
There was a problem hiding this comment.
It would be disappointing to have this redundant URL forever, but we may be stuck at this point, alas.
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
requested changes
May 31, 2024
| @@ -4196,6 +4466,12 @@ To <dfn>generate a verbose debug report URL</dfn> given a [=verbose debug report | |||
| 1. Return the result of running [=generate a report URL=] with |report|'s | |||
| [=verbose debug report/reporting origin=] and |path|. | |||
|
|
|||
| To <dfn>generate an aggregatable debug report URL</dfn> given an [=aggregatable debug report=] |report|: | |||
|
|
|||
| 1. Let |path| be «"`debug`", "`report-aggregate-debug`"». | |||
There was a problem hiding this comment.
It would be disappointing to have this redundant URL forever, but we may be stuck at this point, alas.
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
approved these changes
May 31, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 3, 2024
WICG/attribution-reporting-api#1310 The CL also adds `source_time` to `StoreSourceResult` to set the report time of the aggregatable debug report. Bug: 343870498 Change-Id: I81faa317ebc6282b69c61d2de78e93e6f4bf1da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5577314 Commit-Queue: Nan Lin <linnan@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1309611}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 3, 2024
WICG/attribution-reporting-api#1310 The new table will be integrated with `AttributionStorageSql` in the follow up CL. Bug: 343870498 Change-Id: I645d5bb83e94d522f63a4fd898bf7c3966735613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5576744 Commit-Queue: Nan Lin <linnan@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1309662}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 5, 2024
WICG/attribution-reporting-api#1310 This CL integrates aggregatable debug rate limit table with `AttributionStorageSql` and implements the logic to process aggregatable debug reports. Bug: 343870498 Change-Id: I4f93cf80e74532ccafe05c3e3426ad560c610abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5581813 Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1310708}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is migrated from linnan-github#2
Related to #705
Introduce aggregatable debug reports and rename aggregatable report to aggregatable attribution reports. Aggregatable report is the base class of aggregatable attribution report and aggregatable debug report.
Explainer: https://github.com/WICG/attribution-reporting-api/blob/main/aggregate_debug_reporting.md
Preview | Diff