Replace dedicated JS registration APIs with generic mechanism via fetch #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharrison
reviewed
May 16, 2022
|
Could we add a blurb stating the browser should process responses for any request that has these headers? It would be good to make clear xhr/etc work as well. Otherwise lgtm |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
May 19, 2022
It is being replaced with a more general fetch mechanism: WICG/attribution-reporting-api#428 Bug: 1325874 Change-Id: Iaed47963d99f20fc8bbd0d04cf6e92714980c9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649346 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005332}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
It is being replaced with a more general fetch mechanism: WICG/attribution-reporting-api#428 Bug: 1325874 Change-Id: Iaed47963d99f20fc8bbd0d04cf6e92714980c9f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649346 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005332} NOKEYCHECK=True GitOrigin-RevId: d77d9d7b7251fc0c5fdcf6d4f603dfa8a3020058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#378
Closes #363