Note that the Permission Policy has default * for the Chromium OT #551
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
reviewed
Sep 6, 2022
Co-authored-by: Andrew Paseltiner <apaseltiner@google.com>
apasel422
approved these changes
Sep 6, 2022
apasel422
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Should we also update https://wicg.github.io/attribution-reporting-api/#permission-policy-integration in this PR?
Sure, added the change. |
apasel422
approved these changes
Sep 7, 2022
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 9, 2022
This CL also adds logic for sending a warning issue to devtools if the API was used in a context where it might break in the future when this change is reverted. See WICG/attribution-reporting-api#551 Bug: 1360563 Change-Id: I9a04b3ce9dbab5ab432c963419cb173e232aa881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3877268 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1045172}
blueboxd
pushed a commit
to blueboxd/chromium-legacy
that referenced
this pull request
Sep 29, 2022
This CL also adds logic for sending a warning issue to devtools if the API was used in a context where it might break in the future when this change is reverted. See WICG/attribution-reporting-api#551 (cherry picked from commit e959519) Bug: 1360563 Change-Id: I9a04b3ce9dbab5ab432c963419cb173e232aa881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3877268 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1045172} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3900731 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/branch-heads/5249@{#465} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This CL also adds logic for sending a warning issue to devtools if the API was used in a context where it might break in the future when this change is reverted. See WICG/attribution-reporting-api#551 Bug: 1360563 Change-Id: I9a04b3ce9dbab5ab432c963419cb173e232aa881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3877268 Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: John Delaney <johnidel@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Cr-Commit-Position: refs/heads/main@{#1045172} NOKEYCHECK=True GitOrigin-RevId: e959519cfe885d8387f53a50ba8271465dc06347
|
(Note this PR was meant to address #519, for posterity) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff