Update constructor definition, add factory method #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerate index.html
From the discussion threads, the constructor now creates an empty CSSStyleSheet without loading/parsing. Instead, we add a factory method to return a promise that resolves a new CSSStyleSheet object that contains parsed style sheet from given text.
|
I'm new to editing bikeshed myself, will get it reviewed by Tab or someone later, but Rakina, could |
rakina
reviewed
Jul 6, 2018
| <a>create a MediaList object</a> from the string | ||
| and assign it as <var>sheet’s</var> media. | ||
| Otherwise, assign the value of the attribute as <var>sheet’s</var> media. | ||
| 3. If the {{CSSStyleSheetInit/alternate}} attribute of <var>options</var> is true, | ||
| Otherwise, copy and assign the value of the attribute as <var>sheet’s</var> media. |
There was a problem hiding this comment.
Maybe "assign a copy of the value of the attribute"?
|
A newer pull request (#33) is out now, with createEmptyCSSStyleSheet. Moving it to there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion threads, the constructor now creates an empty
CSSStyleSheet without loading/parsing. Instead, we add a factory
method to return a promise that resolves a new CSSStyleSheet object
that contains parsed style sheet from given text.
Resolves #2, #13.