Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Explicitly perform a CORP check in service worker #3

Merged
merged 3 commits into from
Dec 16, 2019

Conversation

yutakahirano
Copy link
Collaborator

No description provided.

@yutakahirano
Copy link
Collaborator Author

@mikewest, can you take a look?

@annevk and I are talking about COEP and report-only mode at whatwg/html#5100 and I think performing the CORP check explicitly will make things clearer.

cc: @jakearchibald (as cced in the original discussion)

Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this looks good. I left 2 editorial nits inline.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link
Member

@mikewest mikewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One more pass on the note's text? Then I'm happy to land it here. Before we fold it into Fetch, we'll need to file bugs against existing implementations, and make sure to add WPT for this case.

index.bs Outdated Show resolved Hide resolved
@mikewest mikewest merged commit 2ef0479 into WICG:master Dec 16, 2019
@mikewest
Copy link
Member

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants