Drop navigator.identity namespace #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
requested review from
samuelgoto,
RByers and
timcappalli
as code owners
timcappalli
approved these changes
Sep 5, 2024
|
Filed https://bugs.webkit.org/show_bug.cgi?id=279159 for WebKit... I'll update the tests etc. |
bvandersloot-mozilla
approved these changes
Sep 5, 2024
Added chromium implementation bug too. |
|
Updates to the test suite: I need to check these are correct against an engine still, but it's a start. We need to check for redundant tests. |
FWIW, this is already implemented in Chrome Canaries as of last week: https://g-issues.chromium.org/issues/364957810?pli=1&authuser=0 |
|
Great, will try to get WebKit updated soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #???
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff