Update with DOM's abort reason #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ipopescu93, just wondering if you'd be able to take a look at this. Thank you! |
13 tasks
|
LGTM, thanks for taking care of this! |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 31, 2022
This change updates the open() method and abort steps attached to the provided AbortSginal so that the reason provided to the AbortController is used to reject the Promise returned by open(). The web-visible effect of this change is minimal because by default the abort reason is set to the same "AbortError" DOMException which was already used. The corresponding specification change is: WICG/eyedropper-api#25 Change-Id: I414bcd2ae7cd8fba3031c66ba98a5d04b0a7c740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3559669 Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#987267}
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
This change updates the open() method and abort steps attached to the provided AbortSginal so that the reason provided to the AbortController is used to reject the Promise returned by open(). The web-visible effect of this change is minimal because by default the abort reason is set to the same "AbortError" DOMException which was already used. The corresponding specification change is: WICG/eyedropper-api#25 Change-Id: I414bcd2ae7cd8fba3031c66ba98a5d04b0a7c740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3559669 Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Nidhi Jaju <nidhijaju@chromium.org> Cr-Commit-Position: refs/heads/main@{#987267} NOKEYCHECK=True GitOrigin-RevId: fde94645339d474fb580c42312d9f5b376757c03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whatwg/dom#1027 removed the "aborted flag" from DOM's AbortSignal.
This change updates the EyeDropper API spec with the aborted predicate and rejecting promises with the signal's abort reason, instead of with a new "AbortError" DOMException.