-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What does inPlace
do?
#67
Comments
In particular, I'm curious whether or not inPlace would give some form of guarantee of exclusive access, since multiple tabs clobbering the same file seems like asking for trouble. |
I tried to make it bit clearer what inPlace is supposed to be in the documentation for createWriter. Although to be honest I'm not quite sure yet what inPlace=true is going to be like. It seems like we'll want to provide something like that, but it is rather unclear at this point how we will do that while not making it less secure. Because of that the current description of inPlace=true is kind of hand-wavy not really giving any guarantees (and rather giving a lack of guarantees), which makes the difference between it and inPlace=false less clear. |
|
I'm writing a text editor and notice the current implementation in Chrome breaks file watch processes. Since the file is replaced and not updated in place, the file watcher catches the first edit but not subsequent edits. This throws a wrench in development processes which watch files and automatically recompile. Here are example events I caught with inotify.
Those are the events after the first edit. Edits after the first edit do not show up in the file watch. I think what is happening is the file is watched by file ID and not by path. Thus when the original file is deleted Since this method of editing files is not typical, it would be great to have an option to edit in place. |
In response to w3ctag/design-reviews#390
Also, I find
inPlace
confusing. It doesn't explain whatinPlace
does, and repeats the description ofkeepExistingData
's behavior. Our understanding so far is thatinPlace = true
means it will write directly to the destination file without creating a temporary copy first, but it's not clear. So potentially faster, but I though the copy was there because of security and integrity - I understood you never wanted to write incomplete data.The text was updated successfully, but these errors were encountered: