Add algorithms for a couple more methods. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
pwnall
approved these changes
Apr 14, 2020
index.bs
Outdated
| 1. If |name| contains '/' or any other character used as path separator on the underlying | ||
| platform, [=/reject=] |result| with a {{TypeError}} and abort. | ||
|
|
||
| Note: This means that '\' is not allowed in names on Windows, but might be allowed on |
There was a problem hiding this comment.
Do we want to call out what happens with : on Mac?
There was a problem hiding this comment.
What happens or what should happen? "" is the only thing we treat separately in our implementation at least. There are going to be a lot more characters that aren't allowed depending on underlying file system, which I tried to clarify in a non-normative note next to my new definition of "valid file name". Not calling out ";" on mac specifically, although perhaps I should?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
Preview | Diff