Rewrite the permissions logic to integrate with the permissions API. #200

mkruisselbrink · 2020-07-14T22:02:34Z

This is partially editorial (just changing how algorithms check
permissions), but also has a couple of normative changes:

A change from boolean writable to a enum, with currently "read"
and "readwrite" options. This is to keep open the possibility for
write-only handles as discussed in Support write-only handles #119.
Changes from NotAllowedError to SecurityError in a couple of places,
to better align with how other APIs behave.
And of course the integration with navigator.permissions.query,
although that is unlikely to be implemented in chrome any time soon,
as a lot of the infra for that is missing in chrome.

This fixes #120.

Preview | Diff

This is partially editorial (just changing how algorithms check permissions), but also has a couple of normative changes: - A change from `boolean writable` to a enum, with currently "read" and "readwrite" options. This is to keep open the possibility for write-only handles as discussed in #119. - Changes from NotAllowedError to SecurityError in a couple of places, to better align with how other APIs behave. - And of course the integration with navigator.permissions.query, although that is unlikely to be implemented in chrome any time soon, as a lot of the infra for that is missing in chrome. This fixes #120.

pwnall

LGTM w/ two comments.

index.bs

This implements the changes from WICG/file-system-access#200. Change-Id: I9702f9888c4f0fff2084143ac6077b8484dfce16

This implements the changes from WICG/file-system-access#200. Change-Id: I9702f9888c4f0fff2084143ac6077b8484dfce16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298296 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792004}

…ing spec change., a=testonly Automatic update from web-platform-tests [NativeFS] Update permissions API following spec change. This implements the changes from WICG/file-system-access#200. Change-Id: I9702f9888c4f0fff2084143ac6077b8484dfce16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298296 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792004} -- wpt-commits: e85c3405f1269a2ca77ec9e4ea63a4df73ee754e wpt-pr: 24688

…ing spec change., a=testonly Automatic update from web-platform-tests [NativeFS] Update permissions API following spec change. This implements the changes from WICG/file-system-access#200. Change-Id: I9702f9888c4f0fff2084143ac6077b8484dfce16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298296 Reviewed-by: Trent Apted <taptedchromium.org> Reviewed-by: Will Harris <wfhchromium.org> Reviewed-by: Victor Costan <pwnallchromium.org> Commit-Queue: Marijn Kruisselbrink <mekchromium.org> Cr-Commit-Position: refs/heads/master{#792004} -- wpt-commits: e85c3405f1269a2ca77ec9e4ea63a4df73ee754e wpt-pr: 24688 UltraBlame original commit: 6e390caa95e19e686e5068f51f22537f3a1694b7

This implements the changes from WICG/file-system-access#200. Change-Id: I9702f9888c4f0fff2084143ac6077b8484dfce16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298296 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#792004} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 588cb247d7dc0b4356b8bb4b34c35632a5f123b4

mkruisselbrink requested a review from oyiptong July 14, 2020 22:20

mkruisselbrink mentioned this pull request Jul 15, 2020

Add file describing everything that changed since the origin trial #202

Merged

oyiptong approved these changes Jul 15, 2020

View reviewed changes

pwnall self-requested a review July 15, 2020 20:00

pwnall approved these changes Jul 15, 2020

View reviewed changes

index.bs Show resolved Hide resolved

index.bs Outdated Show resolved Hide resolved

must instead of should

315004e

mkruisselbrink mentioned this pull request Jul 16, 2020

Support test automation (use permissions?) #150

Open

mkruisselbrink merged commit a4a44a8 into master Jul 20, 2020

mkruisselbrink deleted the permissions-integration branch July 20, 2020 18:05

mkruisselbrink mentioned this pull request Jul 20, 2020

Updated specs to include Drag and Drop section #192

Merged

chromium-wpt-export-bot mentioned this pull request Jul 23, 2020

[NativeFS] Update permissions API following spec change. web-platform-tests/wpt#24688

Merged

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2020

[NativeFS] Update permissions API following spec change.

6c7ee7f

This implements the changes from WICG/file-system-access#200. Change-Id: I9702f9888c4f0fff2084143ac6077b8484dfce16

mkruisselbrink mentioned this pull request Aug 4, 2020

Native File System API w3ctag/design-reviews#390

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite the permissions logic to integrate with the permissions API. #200

Rewrite the permissions logic to integrate with the permissions API. #200

mkruisselbrink commented Jul 14, 2020 •

edited by pr-preview bot

Loading

pwnall left a comment

Rewrite the permissions logic to integrate with the permissions API. #200

Rewrite the permissions logic to integrate with the permissions API. #200

Conversation

mkruisselbrink commented Jul 14, 2020 • edited by pr-preview bot Loading

pwnall left a comment

Choose a reason for hiding this comment

mkruisselbrink commented Jul 14, 2020 •

edited by pr-preview bot

Loading